Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow uuid on wasm32 and wasi #4965

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

youknowone
Copy link
Member

@youknowone youknowone commented May 11, 2023

@lastmjs
Copy link

lastmjs commented May 11, 2023

I wonder if _signal will be a dependency of other modules though, since signal depends on _signal. This just came up when including uuid.

@lastmjs
Copy link

lastmjs commented May 11, 2023

It worked for uuid though!

@youknowone
Copy link
Member Author

It will be eventually need to be implemented.
platform unnecessarily requires subprocess. and subprocess requires signal.
If you find any problem with platform, It can be also quickly patched.
signal module will take time

@youknowone youknowone merged commit 698134c into RustPython:main May 11, 2023
11 checks passed
@youknowone youknowone deleted the wasmuuid branch May 11, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants