Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sre Engine Implementing to CPython 3.12 #5125

Merged
merged 7 commits into from
Mar 30, 2024
Merged

Update Sre Engine Implementing to CPython 3.12 #5125

merged 7 commits into from
Mar 30, 2024

Conversation

qingshi163
Copy link
Contributor

@qingshi163 qingshi163 commented Nov 26, 2023 •
edited by youknowone

@youknowone
Copy link
Member

@qingshi163 can sre-engine be used as an indepdendent crate out of RustPython? If not, how about putting it in this repository as rustpython-sre-engine?

@qingshi163
Copy link
Contributor Author

@qingshi163 can sre-engine be used as an indepdendent crate out of RustPython? If not, how about putting it in this repository as rustpython-sre-engine?

sure

@qingshi163 qingshi163 changed the title [WIP] Update Sre Engine Implementing to CPython 3.12 Update Sre Engine Implementing to CPython 3.12 Jan 3, 2024
@qingshi163 qingshi163 marked this pull request as ready for review January 3, 2024 15:36
youknowone
youknowone reviewed Feb 10, 2024
View reviewed changes
vm/Cargo.toml Outdated
# to work on sre-engine locally or git version
# sre-engine = { git = "https://github.com/RustPython/sre-engine", rev = "refs/pull/14/head" }
sre-engine = { git = "https://github.com/RustPython/sre-engine", rev = "refs/pull/17/head" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry to forget about this. update to recent release of sre-engine or import the source code here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move the repr to rustpython-sre-engine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to import sre_engine in #5202

@youknowone
Copy link
Member

@qingshi163 other clippy errors looks mostly false positive or trivial. But could you check if clippy::never_loop one is intended or not?

@qingshi163
Copy link
Contributor Author

@qingshi163 other clippy errors looks mostly false positive or trivial. But could you check if clippy::never_loop one is intended or not?

The loop of valued break is needed for performance issue, we just need to ignore the warning

youknowone
youknowone approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove unused code blocks or add a TODO note to share why they are left as commented.

vm/src/stdlib/sre.rs Outdated Show resolved Hide resolved
vm/src/stdlib/sre.rs Outdated Show resolved Hide resolved
@youknowone
Copy link
Member

Please revert the deletion once it is required

@youknowone youknowone merged commit e349b0f into RustPython:main Mar 30, 2024
10 of 11 checks passed
@youknowone youknowone mentioned this pull request Mar 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qingshi163 @youknowone