Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump shutil to 3.12.3 #5228

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Bump shutil to 3.12.3 #5228

merged 3 commits into from
Apr 16, 2024

Conversation

moreal
Copy link
Contributor

@moreal moreal commented Apr 14, 2024

Description

This PR is a PR for successful pip installation along with #5227, #5225 PR. Since get-pip.py needs shutil.rmtree's onexc parameter, I bumped the module to 3.12.3. And I checked that it can install pip and execute pip.

But I'm not sure the DirEntry.is_junction implementation is correct. I just used the code the below parts. It may need more research and confirmation.

let is_junction = cfg!(windows)
&& fs::metadata(&path).map_or(false, |meta| meta.file_type().is_dir())
&& fs::symlink_metadata(&path).map_or(false, |meta| meta.file_type().is_symlink());

Logs (pip installation & pip help)

% cargo run --features=ssl -- --install-pip get-pip                                                                                                                           
   Compiling rustpython-stdlib v0.3.1 (/Users/moreal/github/RustPython/RustPython/stdlib)
   Compiling rustpython v0.3.1 (/Users/moreal/github/RustPython/RustPython)
    Finished dev [unoptimized + debuginfo] target(s) in 3.92s
     Running `target/debug/rustpython --install-pip get-pip`
downloading get-pip.py...
running get-pip.py...
Collecting pip
  Using cached pip-24.0-py3-none-any.whl.metadata (3.6 kB)
Using cached pip-24.0-py3-none-any.whl (2.1 MB)
Installing collected packages: pip
  Attempting uninstall: pip
    Found existing installation: pip 24.0
    Uninstalling pip-24.0:
      Successfully uninstalled pip-24.0
Successfully installed pip-24.0

% cargo run --features=ssl -- -m pip -h
   Compiling rustpython-vm v0.3.1 (/Users/moreal/github/RustPython/RustPython/vm)
   Compiling rustpython-stdlib v0.3.1 (/Users/moreal/github/RustPython/RustPython/stdlib)
   Compiling rustpython v0.3.1 (/Users/moreal/github/RustPython/RustPython)
    Finished dev [unoptimized + debuginfo] target(s) in 8.43s
     Running `target/debug/rustpython -m pip -h`

Usage:   
  /Users/moreal/github/RustPython/RustPython/target/debug/rustpython -m pip <command> [options]

Commands:
  install                     Install packages.
  download                    Download packages.
  uninstall                   Uninstall packages.
  freeze                      Output installed packages in requirements format.
  inspect                     Inspect the python environment.
  list                        List installed packages.
  show                        Show information about installed packages.
  check                       Verify installed packages have compatible dependencies.
  config                      Manage local and global configuration.
  search                      Search PyPI for packages.
  cache                       Inspect and manage pip's wheel cache.
  index                       Inspect information available from package indexes.
  wheel                       Build wheels from your requirements.
  hash                        Compute hashes of package archives.
  completion                  A helper command used for command completion.
  debug                       Show information useful for debugging.
  help                        Show help for commands.

General Options:
  -h, --help                  Show help.
  --debug                     Let unhandled exceptions propagate outside the main subroutine, instead of logging them to stderr.
  --isolated                  Run pip in an isolated mode, ignoring environment variables and user configuration.
  --require-virtualenv        Allow pip to only run in a virtual environment; exit with an error otherwise.
  --python <python>           Run pip with the specified Python interpreter.
  -v, --verbose               Give more output. Option is additive, and can be used up to 3 times.
  -V, --version               Show version and exit.
  -q, --quiet                 Give less output. Option is additive, and can be used up to 3 times (corresponding to WARNING, ERROR, and CRITICAL logging levels).
  --log <path>                Path to a verbose appending log.
  --no-input                  Disable prompting for input.
  --keyring-provider <keyring_provider>
                              Enable the credential lookup via the keyring library if user input is allowed. Specify which mechanism to use [disabled, import, subprocess]. (default: disabled)
  --proxy <proxy>             Specify a proxy in the form scheme://[user:passwd@]proxy.server:port.
  --retries <retries>         Maximum number of retries each connection should attempt (default 5 times).
  --timeout <sec>             Set the socket timeout (default 15 seconds).
  --exists-action <action>    Default action when a path already exists: (s)witch, (i)gnore, (w)ipe, (b)ackup, (a)bort.
  --trusted-host <hostname>   Mark this host or host:port pair as trusted, even though it does not have valid or any HTTPS.
  --cert <path>               Path to PEM-encoded CA certificate bundle. If provided, overrides the default. See 'SSL Certificate Verification' in pip documentation for more information.
  --client-cert <path>        Path to SSL client certificate, a single file containing the private key and the certificate in PEM format.
  --cache-dir <dir>           Store the cache data in <dir>.
  --no-cache-dir              Disable the cache.
  --disable-pip-version-check
                              Don't periodically check PyPI to determine whether a new version of pip is available for download. Implied with --no-index.
  --no-color                  Suppress colored output.
  --no-python-version-warning
                              Silence deprecation warnings for upcoming unsupported Pythons.
  --use-feature <feature>     Enable new functionality, that may be backward incompatible.
  --use-deprecated <feature>  Enable deprecated functionality, that will be removed in the future.

@moreal moreal marked this pull request as draft April 14, 2024 10:40
@youknowone
Copy link
Member

CPython function is here: https://github.com/python/cpython/blob/v3.12.3/Modules/clinic/posixmodule.c.h#L10710-L10728
impl is here: https://github.com/python/cpython/blob/v3.12.3/Modules/posixmodule.c#L14635-L14644

@moreal moreal force-pushed the shutil-bump branch 2 times, most recently from c66dbcb to cff6054 Compare April 16, 2024 14:03
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now everything looks working! Thank you!

@moreal moreal marked this pull request as ready for review April 16, 2024 16:28
@youknowone youknowone merged commit 60993b9 into RustPython:main Apr 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants