Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Config File & Top X ports #126

Closed
wants to merge 2 commits into from
Closed

Conversation

bee-san
Copy link
Member

@bee-san bee-san commented Aug 5, 2020

  • Added Config File
  1. If config file doesn't exist, downloads it
  2. parses the config file as a struct

That's it. It was a lot harder to find the location, download the file if it doesn't exist, and parse it into a struct than I thought as there were so many exceptions 馃槄

To do next:

  • Update opts with the values from the new struct config
  • If it can't download the file, don't panic, inform the user and carry on

This is for #69

@bee-san bee-san changed the title WIP Added Config File & Top X ports Added Config File & Top X ports Aug 19, 2020
@bee-san bee-san marked this pull request as ready for review August 19, 2020 23:24
@bee-san bee-san force-pushed the bee-add-config-file branch 2 times, most recently from 3786078 to a7dc712 Compare August 20, 2020 00:32
@bernardoamc
Copy link
Collaborator

This is super cool. :)

What do you think of extracting all this config logic into it's own module like we do for scanner and port strategy? We can try to keep the main.rs file lean and just care about argument parsing and orchestrating the other modules.

@bee-san
Copy link
Member Author

bee-san commented Aug 21, 2020

This is super cool. :)

What do you think of extracting all this config logic into it's own module like we do for scanner and port strategy? We can try to keep the main.rs file lean and just care about argument parsing and orchestrating the other modules.

I'll work on this now :D

@bee-san bee-san force-pushed the bee-add-config-file branch 2 times, most recently from a218a69 to c509172 Compare August 24, 2020 15:45
@bernardoamc
Copy link
Collaborator

Closing in favour of #185, which expands on the idea and solve conflicts. <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants