Add host resolution #152
Merged
Add host resolution #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bee-san
approved these changes
Aug 15, 2020
For now if we can establish a socket on port 80 we can infer the IP of the host. This might change in the future if we start considering other ports like 443.
bernardoamc
force-pushed
the
ba-add-host-resolution
branch
from
2a1ed28
to
f68abcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now if we can establish a socket on port 80 we can infer the IP of the host. This might change in the future if we start considering other ports like 443 or just use DNS.
Fixes #152