Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Windows support by disabling rlimit for Windows #168

Closed
wants to merge 12 commits into from

Conversation

bee-san
Copy link
Member

@bee-san bee-san commented Aug 26, 2020

  • Disabled rlimit for Windows, allowing Windows support (ulimit is hard-set to 1000 on Windows)
  • Edited README to update help menu
  • Added Windows testing in Travis CI

@bee-san bee-san changed the title Added windows support by disabling rlimit for windows Added Windows support by disabling rlimit for Windows Aug 26, 2020
that enable windows support
src/main.rs Outdated
let ulimit: rlimit::rlim = if !(cfg!(windows)) {
adjust_ulimit_size(&opts)
} else {
1000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we extract this to a constant? Similar to what we are doing for the ports. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can make it a constant, not sure on what you mean by extract though?

Copy link
Collaborator

@bernardoamc bernardoamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to release a new version, there are tons of features that were not released yet. 🎉

@bernardoamc
Copy link
Collaborator

I think we will also need to adjust imports and variable types.

@bee-san
Copy link
Member Author

bee-san commented Aug 26, 2020

I think we will also need to adjust imports and variable types.

Yup! Merely importing the rlimit module requires libc (if I remember the Travis output) which is Linux only. We'd have to find a way to either:

  1. Conditionally import rlimit
  2. Find a new library that doesn't panic when it can't find libc

@bee-san
Copy link
Member Author

bee-san commented Aug 26, 2020

Time to release a new version, there are tons of features that were not released yet. tada

Also, I want to add 1 last feature before release is possible.

When we connect to a socket, if it fails I want it to try X times (as defined via options). It should theoretically be a simple while loop 😄

((we're also going to hit 2k stars today, so a release today would be very apt :) ))

@caass caass mentioned this pull request Aug 26, 2020
@bee-san bee-san closed this Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants