-
-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Windows support by disabling rlimit for Windows #168
Conversation
bee-san
commented
Aug 26, 2020
- Disabled rlimit for Windows, allowing Windows support (ulimit is hard-set to 1000 on Windows)
- Edited README to update help menu
- Added Windows testing in Travis CI
7d6bbb2
to
4bbd394
Compare
src/main.rs
Outdated
let ulimit: rlimit::rlim = if !(cfg!(windows)) { | ||
adjust_ulimit_size(&opts) | ||
} else { | ||
1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we extract this to a constant? Similar to what we are doing for the ports. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can make it a constant, not sure on what you mean by extract though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Time to release a new version, there are tons of features that were not released yet. 🎉
I think we will also need to adjust imports and variable types. |
Yup! Merely importing the
|
Also, I want to add 1 last feature before release is possible. When we connect to a socket, if it fails I want it to try X times (as defined via options). It should theoretically be a simple ((we're also going to hit 2k stars today, so a release today would be very apt :) )) |
89fc777
to
7df1b72
Compare