Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Alpine to 3.19.x #373

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Upgrade Alpine to 3.19.x #373

merged 4 commits into from
Apr 11, 2024

Conversation

gaby
Copy link
Contributor

@gaby gaby commented Mar 30, 2021

  • Upgrade Alpine from 3.17.x -> 3.19.x
  • Upgrade nmap to 7.94
  • Add ca-certificates and bind-tools.
  • Add docker and github-actions to dependabot
  • Update all the Docker related actions
  • Update all the checkout related actions.

Note: Merging this PR will create 8-10 PR's related to Rust outdated actions being used in all the workflows.

Fixes #535

Upgrade alpine to 3.13, add ca-certificates and bind-tools.
@gaby
Copy link
Contributor Author

gaby commented Mar 30, 2021

Is there anyway to see if there was an improvement in performance by upgrading nmap?

@bergabman
Copy link
Contributor

Is there anyway to see if there was an improvement in performance by upgrading nmap?

You can use RUST_LOG=info ./rustscan to see some benchmark data.

@bee-san
Copy link
Member

bee-san commented Apr 7, 2024

@CMNatic thoughts? 🤔

@gaby
Copy link
Contributor Author

gaby commented Apr 7, 2024

@bee-san I will have to update the PR again, it's out of date already 😂

@bee-san
Copy link
Member

bee-san commented Apr 10, 2024

@bee-san I will have to update the PR again, it's out of date already 😂

hahaha ok <3 :)

@CMNatic
Copy link
Contributor

CMNatic commented Apr 10, 2024

Yeah, I wouldn't be opposed to the above @bee-san. It most likely would resolve issue #535 at the very least. I would like to manually test this, though, so once the PR is good to go, LMK :)

cc @gaby

@gaby gaby changed the title Upgrade Alpine to 3.13 Upgrade Alpine to 3.19.x Apr 11, 2024
@gaby
Copy link
Contributor Author

gaby commented Apr 11, 2024

@CMNatic @bee-san PR has been updated. Also added some other small fixes and fixed the merged conflict.

@CMNatic
Copy link
Contributor

CMNatic commented Apr 11, 2024

Thank you:) reviewing on my end 🎉

@CMNatic
Copy link
Contributor

CMNatic commented Apr 11, 2024

I've tested it manually, and all is good on my end @bee-san. It does not solve #535, but that is because the Dockerfile user (rustscan) does not have permission to write to / (the default context), so we will need to modify the Dockerfile to solve that.

@gaby
Copy link
Contributor Author

gaby commented Apr 11, 2024

@CMNatic I found it odd that a non-root user was created for scanning ports 😂

/ ownership could be change, but that could break other things

@gaby
Copy link
Contributor Author

gaby commented Apr 11, 2024

I can remove the rustscan user, mounted directories won't work either unless they are chown/chmod before hand

@CMNatic
Copy link
Contributor

CMNatic commented Apr 11, 2024

I found it odd that a non-root user was created for scanning ports 😂

Yes, me too 😅 we could do that. No reason perse other than it not being best security practice having the tooling run as root. It would mean that files can be saved anywhere i.e. docker run -it --rm --name rustscan rustscan -a 127.0.0..1 -- -Pn -A -oN test.txt, but as you said, mounted directories would need to be chowned and set up.

I think that begins to creep out of the scope for this though / an "advanced" use, similar to bringing your own nmap scripts to run

I'm happy with all of the above @bee-san :) thanks for the contribution (and the skipping docker image CI check)!

@bee-san bee-san merged commit 7f80dd1 into RustScan:master Apr 11, 2024
11 checks passed
@gaby gaby deleted the docker-updates branch April 12, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rustscan cannot saved output anymore with -oN/-oA command
4 participants