-
-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Alpine to 3.19.x #373
Conversation
Upgrade alpine to 3.13, add ca-certificates and bind-tools.
Is there anyway to see if there was an improvement in performance by upgrading nmap? |
You can use |
@CMNatic thoughts? 🤔 |
@bee-san I will have to update the PR again, it's out of date already 😂 |
hahaha ok <3 :) |
Thank you:) reviewing on my end 🎉 |
@CMNatic I found it odd that a non-root user was created for scanning ports 😂 / ownership could be change, but that could break other things |
I can remove the rustscan user, mounted directories won't work either unless they are chown/chmod before hand |
Yes, me too 😅 we could do that. No reason perse other than it not being best security practice having the tooling run as root. It would mean that files can be saved anywhere i.e. I think that begins to creep out of the scope for this though / an "advanced" use, similar to bringing your own nmap scripts to run I'm happy with all of the above @bee-san :) thanks for the contribution (and the skipping docker image CI check)! |
3.17.x
->3.19.x
7.94
ca-certificates
andbind-tools
.Note: Merging this PR will create 8-10 PR's related to Rust outdated actions being used in all the workflows.
Fixes #535