-
-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): add GitHub Action to make release #427
Conversation
26fbd9a
to
52e7d2b
Compare
Merge conflicts :( |
@bee-san, I can look to resolve these but is there still interest in this PR? |
Oooh great question! We have this release.yaml https://github.com/RustScan/RustScan/blob/master/.github/workflows/release.yml But it does not do .deb , and we'd like to make it do .deb 😅 I am thinking you can just copy this PR's yaml into that one? |
@bee-san, sure, I'll take a look. There's some nice matrix-build steps going on in there so I'll try to do something with it. |
Thank you, that would honestly be awesome. Before this we had a bulky Docker-builder to set up debs (feel free to delete https://github.com/RustScan/RustScan/tree/master/rustscan-debbuilder in your PR) 🙈 Because of how cumbersome it was, new releases don't have .deb files :( I was just saying today one of the most important things I should add is .deb building automation!! |
ceea86c
to
5b05f23
Compare
f37a78c
to
cdb21dd
Compare
@bee-san, PR updated.
|
3368fc1
to
5c21d3f
Compare
5c21d3f
to
3e112e0
Compare
as [requested](RustScan#427 (comment)).
3e112e0
to
b024534
Compare
want me to review? looks ok to you? :) |
@bee-san, it works insofar as it generate a As long as you're happy with the changes (and I deleted the right files you mentioned) then LGTM. |
Thanks!! We only build for x86_64-linux? Do you think we should use the matrix to add support for more architectures or? 🤔 |
I'm assuming it would only make sense to build If that changes (say, adding However, I'd probably consider doing that in a separate PR, once this one's proven with the existing arch./release-process…? |
Ok thank you! GitHub's matrix sucks :P |
Thanks, @bee-san! If anything does go awry with this during the next release, please let me know and I'll aim to fix. |
It appears the release did not run? :( https://github.com/PsypherPunk/RustScan/actions/workflows/release.yml
The latest tag is |
@bee-san, can I check how you actually created the tag? Not entirely sure if/why that would matter but I'll take a look 😬 |
I made it in GitHub releases with thank you for your contributions! |
Phew! And there's a |
Add config. to, when a new tag is pushed:
.deb
file usingcargo-deb
;.deb
file in the subsequent release.An example of one such release can be seen here.
Relates #83