Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build CI to auto-distribute releases #468

Merged
merged 4 commits into from
Dec 6, 2022
Merged

Build CI to auto-distribute releases #468

merged 4 commits into from
Dec 6, 2022

Conversation

LeoFVO
Copy link
Contributor

@LeoFVO LeoFVO commented Nov 22, 2022 •
edited

Refactor developper CI.
Removed duplicate CI.
CI make release:

  • build binary
  • publish using cargo
  • cross-compile

@LeoFVO LeoFVO changed the title Build CI to auto-distribute releases WIP: Build CI to auto-distribute releases Nov 22, 2022
@LeoFVO LeoFVO changed the title WIP: Build CI to auto-distribute releases Build CI to auto-distribute releases Nov 22, 2022
@LeoFVO
Copy link
Contributor Author

LeoFVO commented Nov 22, 2022

@bee-san Can you approve workflow allowing me to test my improvements please

@bee-san
Copy link
Member

bee-san commented Nov 22, 2022

Thanks for this <3

Let me know if you need me to add anything to the secrets on GitHub for CI to run :)

@LeoFVO
Copy link
Contributor Author

LeoFVO commented Nov 23, 2022

I'm going to be blocked due to this well know issue #171.
Also there is some code block to refactor to pass clippy tests, I'll try to fix some.

@bee-san
Copy link
Member

bee-san commented Nov 23, 2022

Ahh Windows support shouldn't be that difficult, #449 upgraded the rlimit crate which adds support for Windows (which is why we didn't have it)

I do not have a Windows PC to test 🤔 but I imagine it's just fixing somethings until the CI works? 🤔

@LeoFVO
Copy link
Contributor Author

LeoFVO commented Nov 23, 2022 •
edited

@bee-san I fixed all troubles about clippy, linting stage should pass now.
Also tried to fix test on window, need CI to be run to confirm.
Thanks ;)

@LeoFVO
refactor(ci): update build ci and add cross-compilation
c99dc79 
* cron check
* remove fmt
* cross-compile for tests
* lint code
* remove duplicate

Signed-off-by: leofvo <leofvo@proton.me>
@LeoFVO
fix(code): code lint + fix bad practices
0eeeb73 
Signed-off-by: leofvo <leofvo@proton.me>
@LeoFVO
test(windows): remove windows incompatible function for test when run…
59b67f3 
…ning on windows

Signed-off-by: leofvo <leofvo@proton.me>
@LeoFVO
Copy link
Contributor Author

LeoFVO commented Dec 5, 2022

Hey @bee-san, I just fixed things and reorganized commits. Can you launch the github action to confirm please.
Also, we will need to set a github secret named : CRATES_TOKEN and the value have to be created from here https://crates.io/settings/tokens

Thanks for your help!

@LeoFVO
Copy link
Contributor Author

LeoFVO commented Dec 5, 2022

It's seems that aarch64-linux doesn't have python pre-installed, I just removed aarch64 for now to check if release build work fine. Need CI to be triggered again.

@bee-san
Copy link
Member

bee-san commented Dec 5, 2022

It's seems that aarch64-linux doesn't have python pre-installed, I just removed aarch64 for now to check if release build work fine. Need CI to be triggered again.

Thanks! Apologies for GitHub CI making me approve it, once it's merged your future PRs will be auto-run 😅

@LeoFVO
build(release): add release ci/cd
1ae0e65 
* github workflow
* cargo.toml improvment

Signed-off-by: leofvo <leofvo@proton.me>
@LeoFVO
Copy link
Contributor Author

LeoFVO commented Dec 6, 2022 •
edited

Thanks! Apologies for GitHub CI making me approve it, once it's merged your future PRs will be auto-run 😅

It's OK :)
It's slow me a bit but np, If you want I can do a simple "fix typo" PR and you merge it to allow me auto-trigger the pipeline. As you want.

Btw, pipeline need to be trigger again :) windows is causing troubles xP

@bee-san
Copy link
Member

bee-san commented Dec 6, 2022

🥳

@bee-san bee-san merged commit 405f05d into RustScan:master Dec 6, 2022
@bee-san
Copy link
Member

bee-san commented Dec 6, 2022

Thanks so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bee-san bee-san bee-san approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LeoFVO @bee-san