Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prometheus label ordering #268

Merged
merged 1 commit into from
May 19, 2022
Merged

Fix prometheus label ordering #268

merged 1 commit into from
May 19, 2022

Conversation

RustedBones
Copy link
Owner

Ordering of the dimensions was non consistent when server dimensions
were set.

Fix #266

Make a clear split between

  • serverDimensions
  • requestDimensions
  • responseDimensions

Add unit test for ordering to catch undesired change.

Ordering of the dimensions was non consistent when server dimensions
were set
@RustedBones RustedBones merged commit d912746 into main May 19, 2022
@RustedBones RustedBones deleted the fix-prometheus-labeling branch May 19, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: prometheus label issues in 1.7.0
1 participant