ActivityDefinition InteractionType #17
Conversation
ActivityDefinition has been extended to include: interactionType correctResponsesPattern choices scale target step This as been based on the work carried out by Paul Carpenter and is my first GitHub submission.
| # Visual Studio 2012 | ||
| # Visual Studio 2013 | ||
| VisualStudioVersion = 12.0.31101.0 | ||
| MinimumVisualStudioVersion = 10.0.40219.1 |
There was a problem hiding this comment.
Can we revert these changes, at least the change from VS 2012 to VS2013. Though I don't really know what they are for. Any explanation or just the IDE doing automatic things? In general we should avoid making these kinds of changes if possible.
There was a problem hiding this comment.
Neither VS2017 nor Rider require the lines VisualStudioVersion... and MinimumVisualStudioVersion...
In some projects it makes sense to keep such constraints in the sln files, such as those which depend on the UML-to-Code transformations which were included in previous VS versions but were removed in VS 2017.
I suggest the additions to be discarded while the deletion to be kept.
|
Sorry for the delay on this, I'm trying to give our OSS libs some love. |
|
This code works. I did follow @brianjmiller suggestion that constant names should be capitalized, and changed the code to use the defined constants. |
|
I need the features provided by this request, why is this yet to be merged? |
|
@peturingi this needs somebody to work through the PR and make the changes as suggested by @brianjmiller in his review, then probably open a new PR with those changes included. |
ghost
mentioned this pull request
|
@garemoko @brianjmiller I made the changes and created a new PR. |
ActivityDefinition has been extended to include:
interactionType
correctResponsesPattern
choices
scale
target
step
This as been based on the work carried out by Paul Carpenter and is my first GitHub submission.