Convert to Sopel 7+ URL handling #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 075bcb6 into 13ae69b - view on LGTM.com new alerts:
|
dgw
force-pushed
the
url-decorator
branch
2 times, most recently
from
a5f6b71
to
6b0a89b
Compare
|
Not sure how I missed this :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically the
@urldecorator works on older Sopel versions, but 1) they're no longer supported and 2) it stops handling links if theurl(title-fetcher) plugin is disabled (sopel-irc/sopel#1489).The trade-off here is that you can match more than one link in an IRC line with
@url(I guess see sopel-irc/sopel#1757), but need to require at least Sopel 7.0 to make the plugin reliable without using@rule.I added an upper bound on the Sopel version "just in case". No current API change plans should affect this plugin until after 9.x, but it's probably good to test and release version bumps around when new Sopel releases drop anyway.