Pass CanBeNull to string serializer and converter #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #25.
The IStringConverter and IStringSerializer was modified to receive DeserializeOptions as last parameter of Deserialize method. That contains CanBeNull. Serialize assumes null shall be serialized as null, no options need to be passed. If there is an object that may not be null and it will be serialized, it should not be null in the first place, that's the reason serialize options are not needed.
When CanBeNull is true, the behavior is the same. When it's null, "null strings" ("-1", "-") are treated like their actual value instead of null.