Revert to Swift 4.2 #145
Merged
Revert to Swift 4.2 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryne Cheow <rynecheow@gmail.com>
sunshinejr
approved these changes
Apr 28, 2019
CHANGELOG.md
Outdated
| ## 4.5.0 | ||
|
|
||
| #### Fixed | ||
| * #144 until RxSwift 5.0.0 is released |
There was a problem hiding this comment.
how about something like "Updated Carthage minimum Swift version to 4.2"?
There was a problem hiding this comment.
I think it's just "Minimum Swift version is 4.2 (More details in #144)"
There was a problem hiding this comment.
Yeah, anything that would say what was updated without me needing to go to the GitHub issue to find out.
Signed-off-by: Ryne Cheow <ryne_cheow@ntucenterprise.sg>
|
PR updated! |
Merged
|
@freak4pc @sunshinejr Is this PR good to go yet? |
|
@rynecheow yeah I think so 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve #144 until RxSwift 5.0.0 is released