Added method to expose DataResponse - RxAlamofire.request(...).responseJSON().

[freak4pc]

This PR aims to resolve issue #76

This PR allows using the following syntax to access the underlying DataResponse object of a request:

RxAlamofire
    .request(.get, "https://jsonplaceholder.typicode.com/posts/1") // Returns Observable<DataRequest>
    .responseJSON() // Returns Observable<DataResponse<Any>>
    .subscribe(onNext: { response in
        print(String(describing: response.result.value))
        print(response.timeline)
    })
    .addDisposableTo(disposeBag)

[sergdort]

I wonder if we should send onError in this case as it's part of the response?

[freak4pc]

I also contemplated with that. But if we skip the error part and let the request push the error, you would end up with both an error and a next event (next sent first along with an error). I had it set up this way but wasn't sure if it makes sense, I'm down changing back if it makes more sense but I'm worried on the underlying possible confusion.

[freak4pc]

So what's our final opinion on this one? We ca go either way @sergdort

[sergdort]

not sure of it's nicer but you can also do

return Disposables.create(request.cancel)

[freak4pc]

Uhm yeah sure I'll add that! I usually prefer doing the closure for readability but for a one liner that's nicer for sure. Thanks !

[freak4pc]

Actually this would have to be
Disposables.create(with: request.cancel)

Which really isn't as neat. I think I'll leave this with a regular closure as its a bit easier on the eye. @sergdort

[RafaelPlantard]

👍

[freak4pc]

Could anyone help with pushing this through or giving a review? It's been sitting here for 20+ days.

@RxSwiftCommunity/contributors

[ashfurrow]

Thanks for the poke, the PR makes sense to me but I admit I haven't used the library extensively, so another set of eyes couldn't hurt. If in doubt, merge and we can figure out the problems later 👍 Thanks again!

[RafaelPlantard]

Great!

[RafaelPlantard]

👍