Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You should make RxViewModel class "open" #50

Closed
lovesuper opened this issue Jul 25, 2017 · 3 comments
Closed

You should make RxViewModel class "open" #50

lovesuper opened this issue Jul 25, 2017 · 3 comments
Assignees
@esttorhe
Labels
bug status:confirmed

Comments

@lovesuper
Copy link

I have Cannot inherit from non-open class 'RxViewModel' outside of its defining module all around my project because of you annotate rxviewmodel class with "public" annotation instead of "open"
esttorhe added a commit that referenced this issue Jul 25, 2017
@esttorhe
🐛 Marks RxViewModel as open
a498659 
When `RxViewModel` was created `Swift` only had 3 access levels; and
thus marking it as `public` would suffice for subclassing; with `Swift`
3 this changed and we never got around modifying the access level on the
class to be `open` as reported on #50.
@esttorhe esttorhe self-assigned this Jul 25, 2017
@esttorhe
Copy link
Member

You are 💯 correct @lovesuper.

I just replaced the one public usage for open to make the class subclassable.

Once CI is 💚 I'll merge and release a new version.

@esttorhe esttorhe mentioned this issue Jul 25, 2017
Merged
esttorhe added a commit that referenced this issue Jul 25, 2017
@esttorhe
🐛 Marks RxViewModel as open (#51)
2838e8c 
* 🐛 Marks `RxViewModel` as `open`
When `RxViewModel` was created `Swift` only had 3 access levels; and
thus marking it as `public` would suffice for subclassing; with `Swift`
3 this changed and we never got around modifying the access level on the
class to be `open` as reported on #50.

* 🔧 Fixes Codecov config
@esttorhe
Copy link
Member

This should be fixed now; i'll release a new version in the next hour

@esttorhe
Copy link
Member

🚫 done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esttorhe esttorhe

Labels
bug status:confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lovesuper @esttorhe