-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests don't pass on master #6
Comments
Assertion value is right. Irrespective of the requested thumbnail dimensions, I always find the actual value is offset by 1px. |
Interesting leads here. |
Regardless of the discussion on node-fluent-ffmpeg, we should probably do something so that the tests pass. If node-fluent-ffmpeg automatically does the rounding and there's nothing we can do to change that, we should probably just document that the rounding happens and update the test to account for it. Most users probably don't care if the generated thumb is 1px off of the requested value. Most people also probably request even resolutions or just use the default The only case where it could be problematic would be if someone was relying on getting an image with the exact dimensions that they requested, but since the library already will change dimensions to ensure the aspect ratio is correct, I don't think we should worry about that case. |
It looks like maybe the assertion value is simply wrong?
The text was updated successfully, but these errors were encountered: