Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What's the reason behind rounding to multiples of two #910

Closed
RyanAfrish7 opened this issue Jun 12, 2019 · 2 comments
Closed

What's the reason behind rounding to multiples of two #910

RyanAfrish7 opened this issue Jun 12, 2019 · 2 comments
Labels
Question

Comments

@RyanAfrish7
Copy link

I have been facing size issues with the screenshots generated. Most times I find it offset by 1 pixel. Just now going thru the code pointed me out this. Please add this to the documentation if this is unavoidable.

node-fluent-ffmpeg/lib/options/videosize.js

Line 95 in 22db625

// Round target size to multiples of 2

@RyanAfrish7 RyanAfrish7 mentioned this issue Jun 12, 2019
Open
@njoyard
Copy link
Member

njoyard commented Jun 13, 2019

Because many codecs require multiples of two (eg. x264)

@njoyard njoyard closed this as completed Jun 28, 2019
@kj800x
Copy link

kj800x commented Jul 30, 2019

Is this documented anywhere?

Related: RyanAfrish7/thumbsupply#6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@njoyard @kj800x @RyanAfrish7