Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support template-haskell 2.17, plus unlifted fix. #44

Closed
wants to merge 1 commit into from

Conversation

galenhuntington
Copy link

Most changes are to use the new Code newtype (https://gitlab.haskell.org/ghc/ghc/-/merge_requests/3358).

Also, while I was in there I took the opportunity to fix #43.

Note that I had to use your explicit-specificity branch of th-abstraction to build, since it's a dependency. Bounds adjusted accordingly.

@RyanGlScott
Copy link
Owner

Thanks for the PR. Do note that I already have a quote branch in the works which aims to solve this same problem, but it performs some additional refactoring to minimize the amount of CPP that needs to be used.

@galenhuntington
Copy link
Author

Ah, I didn't see that.

@galenhuntington
Copy link
Author

From the looks of it, there's nothing new in this PR then, so I'll close.

@RyanGlScott
Copy link
Owner

Admittedly, branches aren't the most easily discoverable things. I've opened #45 with the current state of the quote branch to more widely advertise its existence. With luck, that branch should continue to work once GHC 9.0.1-alpha1 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deriveLift-generated instance for unlifted newtype fails to typecheck
2 participants