Skip to content

Commit

Permalink
Reconfigured for .NET 8, dropping legacy versions.
Browse files Browse the repository at this point in the history
  • Loading branch information
RyanLamansky committed Mar 3, 2024
1 parent 53e4390 commit 8e3b194
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 16 deletions.
12 changes: 2 additions & 10 deletions .github/workflows/dotnetcore.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,10 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Setup .NET Core 3.1
- name: Setup .NET 8
uses: actions/setup-dotnet@v3
with:
dotnet-version: 3.1.x
- name: Setup .NET 6
uses: actions/setup-dotnet@v3
with:
dotnet-version: 6.0.x
- name: Setup .NET 7
uses: actions/setup-dotnet@v3
with:
dotnet-version: 7.0.x
dotnet-version: 8.0.x
- name: Install dependencies
run: dotnet restore
# Debug and Release might be different due to conditional compilation, so validate both.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<DebugType>embedded</DebugType>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion Examples/ReadMeSample/ReadMeSample.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion Examples/RunExisting/RunExisting.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
Expand Down
4 changes: 4 additions & 0 deletions WebAssembly.Tests/Runtime/SpecTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,10 @@ public void SpecTest_float_exprs()
{
skips.Add(2351);
skips.Add(2357);

// Found starting in .NET 8.
skips.Add(2353);
skips.Add(2359);
}

SpecTestRunner.Run(Path.Combine("Runtime", "SpecTestData", "float_exprs"), "float_exprs.json", skips.Contains);
Expand Down
2 changes: 1 addition & 1 deletion WebAssembly.Tests/WebAssembly.Tests.csproj
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netcoreapp3.1;net6.0;net7.0</TargetFrameworks>
<TargetFramework>net8.0</TargetFramework>
<LangVersion>10.0</LangVersion>
<RootNamespace>WebAssembly</RootNamespace>
<Nullable>enable</Nullable>
Expand Down
4 changes: 2 additions & 2 deletions WebAssembly/WebAssembly.csproj
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<!-- .NET Core 3.1 is selected as the baseline for a good balance of compatibility and features, and is fully supported by .NET 5+. -->
<TargetFrameworks>netcoreapp3.1;netstandard2.0</TargetFrameworks>
<!-- I'd prefer to set a much older .NET Core as the baseline but it's not currently worth the inconvenience. -->
<TargetFrameworks>net8.0;netstandard2.0</TargetFrameworks>
<Title>WebAssembly for .NET</Title>
<AssemblyTitle>WebAssembly for .NET</AssemblyTitle>
<Authors>Ryan Lamansky</Authors>
Expand Down

0 comments on commit 8e3b194

Please sign in to comment.