Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom font support #20

Merged
merged 3 commits into from
Nov 18, 2023
Merged

Add custom font support #20

merged 3 commits into from
Nov 18, 2023

Conversation

RyanLua
Copy link
Owner

@RyanLua RyanLua commented Oct 29, 2023

Description

Adds an attribute that allows the font to be changed.

Related Issues

Closes #19

Changes Made

  • Add new constant to get font attributes
  • Update the UI to use the user defined font

Checklist

  • I have tested these changes thoroughly.
  • I have reviewed my code for any potential errors or issues.
  • I have followed the code style guidelines for this project.

Additional Notes

Rojo does not support Font syncing via Instance Attributes but you can add the attribute yourself. Else it will fallback to the Gotham SSm font.

Code of Conduct

By submitting this issue, I agree to follow the Code of Conduct.

Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
@RyanLua RyanLua self-assigned this Oct 29, 2023
@RyanLua RyanLua added the enhancement New feature or request label Oct 29, 2023
@RyanLua RyanLua added this to the v1.2.0 milestone Oct 29, 2023
@RyanLua
Copy link
Owner Author

RyanLua commented Oct 30, 2023

Some fonts don't properly weight so now I need to solve that.

@RyanLua RyanLua changed the title Add WIP font changing Add custom font support Nov 18, 2023
@RyanLua RyanLua marked this pull request as ready for review November 18, 2023 06:22
Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
@RyanLua RyanLua merged commit 2eadec3 into main Nov 18, 2023
6 checks passed
@RyanLua RyanLua deleted the font-attribute branch November 18, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add font attribute
1 participant