Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy embed of selection #30

Closed
math-feng opened this issue Feb 2, 2024 · 1 comment
Closed

copy embed of selection #30

math-feng opened this issue Feb 2, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@math-feng
Copy link

math-feng commented Feb 2, 2024

Why is it that when I select copy embed of selection, the link after pasting is an embed of the whole PDF?

It should be a bug!
Change the setting to the one shown below and it works fine, before it was {{link}}.
image

@RyotaUshio RyotaUshio added the bug Something isn't working label Feb 2, 2024
@RyotaUshio
Copy link
Owner

Thanks! Now the link template variable contains a subpath such as #page=1&selection=0,1,2,3&color=red.

RyotaUshio added a commit that referenced this issue Feb 2, 2024
commit aebf0a0
Author: RyotaUshio <ushio@ms.k.u-tokyo.ac.jp>
Date:   Fri Feb 2 17:37:47 2024 +0900

    refactor folder strcture

commit ecd62d1
Author: RyotaUshio <ushio@ms.k.u-tokyo.ac.jp>
Date:   Fri Feb 2 17:30:03 2024 +0900

    update readme

commit c09f52e
Author: RyotaUshio <ushio@ms.k.u-tokyo.ac.jp>
Date:   Fri Feb 2 17:20:32 2024 +0900

    Enable adding highlight annotations with pdf-lib

commit 7af3c22
Merge: 8ba454b 3fee9d0
Author: RyotaUshio <ushio@ms.k.u-tokyo.ac.jp>
Date:   Fri Feb 2 15:46:12 2024 +0900

    Merge branch 'main' into pdf-lib

commit 8ba454b
Author: RyotaUshio <ushio@ms.k.u-tokyo.ac.jp>
Date:   Fri Feb 2 15:28:46 2024 +0900

    Fix #30: the 'link' template variable is lacking subpath

commit a05f41a
Author: RyotaUshio <ushio@ms.k.u-tokyo.ac.jp>
Date:   Fri Feb 2 15:24:37 2024 +0900

    cleanup

commit 538acea
Author: RyotaUshio <ushio@ms.k.u-tokyo.ac.jp>
Date:   Fri Feb 2 15:22:00 2024 +0900

    add Contents entry in pdf-lib writer

commit de681e4
Author: RyotaUshio <ushio@ms.k.u-tokyo.ac.jp>
Date:   Fri Feb 2 15:19:15 2024 +0900

    enable writing highlights with pdf-lib, but cannot see it in the annotatioin layer

commit 5db2dc8
Author: RyotaUshio <ushio@ms.k.u-tokyo.ac.jp>
Date:   Fri Feb 2 15:13:08 2024 +0900

    add highlight color CSS variables & get highlight annotation rgb values from the variables when writing into file

commit b665715
Author: RyotaUshio <ushio@ms.k.u-tokyo.ac.jp>
Date:   Fri Feb 2 06:44:10 2024 +0900

    pdfAnnotateIO now can group rectangles into one using quadPoints

commit 32b365c
Merge: 4a35bce 9516d87
Author: RyotaUshio <ushio@ms.k.u-tokyo.ac.jp>
Date:   Fri Feb 2 06:18:17 2024 +0900

    Merge branch 'main' into pdf-lib

commit 4a35bce
Author: RyotaUshio <ushio@ms.k.u-tokyo.ac.jp>
Date:   Fri Feb 2 01:55:49 2024 +0900

    temp commit

commit 273c15b
Author: RyotaUshio <ushio@ms.k.u-tokyo.ac.jp>
Date:   Fri Feb 2 01:05:22 2024 +0900

    refactor

commit f80a241
Author: RyotaUshio <ushio@ms.k.u-tokyo.ac.jp>
Date:   Fri Feb 2 00:21:57 2024 +0900

    add @cantoo/pdf-lib as a dependency. it's a well-maintained fork of the original pdf-lib, which seems to be abondoned

commit f058056
Author: RyotaUshio <ushio@ms.k.u-tokyo.ac.jp>
Date:   Thu Feb 1 23:23:51 2024 +0900

    update comment

commit e9f6e6c
Author: RyotaUshio <ushio@ms.k.u-tokyo.ac.jp>
Date:   Thu Feb 1 23:22:41 2024 +0900

    update annotation id naming rule

commit 9eabd79
Author: RyotaUshio <ushio@ms.k.u-tokyo.ac.jp>
Date:   Thu Feb 1 21:23:42 2024 +0900

    add showStatusInToolbar option

commit 2c42390
Author: RyotaUshio <ushio@ms.k.u-tokyo.ac.jp>
Date:   Thu Feb 1 21:08:49 2024 +0900

    cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants