-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Use search
in link instead of bounding box and selection
#92
Comments
…call of 'child.applySubpath' at the top of 'highlightSubpath'. As a result, we need to store the first subpath to be opened after PDF++ is enabled, so added 'plugin.subpathWhenPatched' and use it in 'onPDFInternalsPatchSuccess'.
First of all, thank you so much for the sponsorship! I really appreciate your support.
The You can copy a link with the |
However, text search in PDF is expensive, so it might be difficult to use |
That's absolutely awesome - thanks so much! I can imagine that search is expensive so backlinks with search won't work. Suppose I would be writing my own extension on PDF++ - would it be possible to hook in to an API call or something else that I would input the search phrase and get the |
I just noticed: when opening a backlink that contains a search parameter the PDF is focused, which is different from opening a backlink that has a |
Describe your request
Thanks for writing PDF++ - I had never imagined this level of integration would be possible in Obsidian. I'm wondering if it would be possible to create links which link through the selected text instead of the
selection
offsets. As I can see nowselection
is already just referencing the text layer:obsidian-pdf-plus/src/lib/copy-link.ts
Line 42 in 11f16fd
Would it be possible to configure an option that is not creating a
selection
but asearch
parameter? As a first step, it would already be helpful if asearch
parameter would execute a search in the PDF and scroll to the found text. Having it similar toselection
would also help with having permanent highlights.My use case is that I'm creating the highlights in different ways than through the PDF. E.g. I've got a lot of clipped content from webpages. I'm adding selected text from that webpage in a file, that I later want to search back in the captured PDF. I'm wondering if an option for that would be possible.
The advanced use case here I'm after is having one link in frontmatter with a source PDF (as can already be done with PDF++ - awesome!) and automatically adding links after quotations based on the text. I've got a plugin ready that can already do the automatic linking.
The text was updated successfully, but these errors were encountered: