fix ek mandate.1 "add_character_modifier" bug #582
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug review
Here you @TypicalCrusader used primary_title, set variable inside title scope, and a character modifier,
so I wrapped these character-scoped actions to PREV, relating to title holder (Earth King)
Result
Before:
After:
and the error in error.log disappeared
BTW
As I can see, setting a variable inside a title scope seems to be the same as setting it inside a character scope
But, maybe you @TypicalCrusader wanted to "change_" it, not to "set_" it? Like, now it was 50, now it's -10. Would'nt it be better to change it, like it was 50, then it's 40?