--keep-files works now but the temporary directory won't get removed

[mikelei8291]

Describe the bug
After fixing #71 in commit 7fad013, a new bug was introduced that the files in the temporary directory will be removed but not the directory itself if --keep-files was NOT used.

To Reproduce
twspace_dl --input-cookie-file twitter.txt -suU "https://twitter.com/username" -m -v

Expected behavior
Temporary directories and their content got removed after running the command when --keep-files was not used.

Output

Desktop (please complete the following information):

• OS: Ubuntu Linux 22.04.1 LTS
• twspace-dl Version: 6c57161
• Installation method: pip from GitHub repo

[Ryu1845]

I'll investigate, I don't see where the bug is at first glance

[mikelei8291]

OK I got it, it was because I used the -s (--skip-download) option.

Before 7c309c0 the function call tempfile.mkdtemp(dir=".") was done in the download() method of the TwspaceDL class:

twspace-dl/twspace_dl/twspace_dl.py

Line 102 in dca4c2f

tempdir = self._tmpdir = tempfile.mkdtemp(dir=".")

So when the -s option was used the temp directory was not actually created at all, as the download() method would only be called if the -s option was not specified:

twspace-dl/twspace_dl/__main__.py

Lines 122 to 124 in 7fad013

	if not args.skip_download:
	try:
	twspace_dl.download()

However, they made a mistake in 7c309c0 that the call to tempfile.TemporaryDirectory(dir=".") was done in the constructor of the TwspaceDL class, thus creating an empty temp directory every time the class was instantiated. After fixing #71, you only changed the function call in the constructor back to tempfile.mkdtemp(dir="."), but the directory won't get removed by the shutil.rmtree(twspace_dl.tempdir) call as the condition to the if statement would be False when the -s option was specified.

twspace-dl/twspace_dl/__main__.py

Lines 122 to 129 in 7fad013

	if not args.skip_download:
	try:
	twspace_dl.download()
	except KeyboardInterrupt:
	logging.info("Download Interrupted by user")
	finally:
	if not args.keep_files and os.path.exists(twspace_dl.tempdir):
	shutil.rmtree(twspace_dl.tempdir)

Therefore, I would suggest to revert back the changes done in 7c309c0, especially L102 in twspace_dl/twspace_dl.py to fix this issue.