Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new user ID API rate limit and temp directory not being removed issue #87

Merged
merged 4 commits into from
Feb 10, 2023
Merged

Conversation

mikelei8291
Copy link
Contributor

@mikelei8291 mikelei8291 commented Feb 9, 2023

Fixes #82.
Fixes #73.

The file location of the proposed on-disk guest_token cache was set to a file in the temp directory on the system as it was rotated fairly often.

@mikelei8291 mikelei8291 changed the title Fix new user ID rate limit issue Fix new user ID API rate limit and temp directory not being removed issue Feb 9, 2023
@mikelei8291
Copy link
Contributor Author

Now also fixes #73.

@Ryu1845
Copy link
Collaborator

Ryu1845 commented Feb 9, 2023

Thank you! Can I merge or do you want to add other things?

@mikelei8291
Copy link
Contributor Author

That's all the things I've fixed, you can merge now. Thanks!

@mikelei8291
Copy link
Contributor Author

Also I've tested these fixes on my end and they all worked fine.

@mikelei8291
Copy link
Contributor Author

OK maybe one more thing. I've noticed this issue for a long time but didn't think it was worth fixing on its own so here you go.

@mikelei8291
Copy link
Contributor Author

Now you can merge it if the CI passes.

Copy link
Collaborator

@Ryu1845 Ryu1845 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the typo that looks good to me. I'll merge as soon as it's fixed.

twspace_dl/twitter.py Outdated Show resolved Hide resolved
@mikelei8291
Copy link
Contributor Author

I fixed the typo. Shouldn't have happen.. I was thinking if it was correct but was too lazy to use a type checker...

@Ryu1845 Ryu1845 merged commit 0988b17 into HoloArchivists:main Feb 10, 2023
@mikelei8291
Copy link
Contributor Author

OK maybe one more thing. I've noticed this issue for a long time but didn't think it was worth fixing on its own so here you go.

Sorry I forgot to include the commit that I fixed the markdown rendering issue in README when I force pushed to fix the typo. Do you want me to add that commit back?

image
image

@Ryu1845
Copy link
Collaborator

Ryu1845 commented Feb 10, 2023

I'll do it, don't worry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rate limit on guest_token API --keep-files works now but the temporary directory won't get removed
2 participants