-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix new user ID API rate limit and temp directory not being removed issue #87
Conversation
Now also fixes #73. |
Thank you! Can I merge or do you want to add other things? |
That's all the things I've fixed, you can merge now. Thanks! |
Also I've tested these fixes on my end and they all worked fine. |
OK maybe one more thing. I've noticed this issue for a long time but didn't think it was worth fixing on its own so here you go. |
Now you can merge it if the CI passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside the typo that looks good to me. I'll merge as soon as it's fixed.
I fixed the typo. Shouldn't have happen.. I was thinking if it was correct but was too lazy to use a type checker... |
I'll do it, don't worry |
Fixes #82.
Fixes #73.
The file location of the proposed on-disk
guest_token
cache was set to a file in the temp directory on the system as it was rotated fairly often.