Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] 5.1 Surround sound support #4422

Closed
ghost opened this issue Feb 14, 2023 · 11 comments · Fixed by #4894
Closed

[Feature Request] 5.1 Surround sound support #4422

ghost opened this issue Feb 14, 2023 · 11 comments · Fixed by #4894

Comments

@ghost
Copy link

ghost commented Feb 14, 2023

Overview

Currently Ryujinx only seems to output Stereo.

Smaller details

Yuzu has a option to pick the system sound mode directly, Stereo or Surround.

Nature of request

Sound.

Why would this feature be useful?

5.1 support is common place in home setups.

@turntable97
Copy link

Can't wait for this to be implemented. :)

@gdkchan
Copy link
Member

gdkchan commented Feb 27, 2023

I believe this is already supported (it should use 5.1 output as long the audio device being used supports it).

@ghost
Copy link
Author

ghost commented Feb 27, 2023

I believe this is already supported (it should use 5.1 output as long the audio device being used supports it).

This is incorrect or there's a bug preventing it from outputting correctly. I have Dolby Atmos selected in windows sound settings and I am only get 2.0 channels of sound versus Yuzu's 5.1. I also tried all the backends with no change.

@gdkchan
Copy link
Member

gdkchan commented Feb 27, 2023

It should use 5.1 as long the game is outputting 5.1 audio. If the game only has stereo output then it will only have 2 channels.

@ghost
Copy link
Author

ghost commented Feb 27, 2023

You can test this with Metroid Prime Remastered main menu music. I assure you there is no output from the surround speakers, only L and R.

@ghost ghost changed the title [Feature Request] Surround sound support [Feature Request] 5.1 Surround sound support Feb 28, 2023
@jojodunet
Copy link

Why not also adding a feature to test all 5.1 channels in the Ava UI sound menu?

@jordanvachon
Copy link

yup no direct 5.1

@ShinKaz
Copy link

ShinKaz commented May 1, 2023

same here no 5.1 in BOTW for instance, wish Ryujinx would support this so bad. Thanks for your hard work !

@samdnz
Copy link

samdnz commented May 4, 2023

can confirm this is disabled

The audio dsp has a comment noting the channel polling is disabled until an upmixer is implemented. Perhaps an unsafe option could be added?

@ghost
Copy link
Author

ghost commented May 11, 2023

As of 1.1.783 5.1 surround sound is still not working. I had hopes as the changelog mentioned changes:

AUDIO:
- amadeus: Fix wrong channel mapping check and an old typo.
  - Fixes broken audio in The Legend of Zelda: Tears of the Kingdom.

Dolby Atmos is set in Control Panel (7.1 setup, channel upmixer off)

I think Ryu team will need to implement the Switch's "Sound Output Mode" option so we can pick Stereo or Surround Sound.

@Glebman95
Copy link

Funny thing is: it used to work on older versions. When the issue with the surround started I used a yuzu sdl2.dll for Ryujinx and it worked. Recently they changed it somehow, so that workaround doesn't work anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants