Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Graphical regression in Splatoon 3 on version 1.1.741 and onwards #5239

Closed
CosmicDreamsOfCode opened this issue Jun 5, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@CosmicDreamsOfCode
Copy link

Description of the issue

Lighting in some scenes has been broken since version 1.1.741 of Ryujinx and onwards.
1.1.740 works, all versions after have the issue.
image

Reproduction steps

Enter customization menu or view match EOR sequence.

Log file

Ryujinx_1.1.869_2023-06-05_18-04-34.log

OS

Windows 10

Ryujinx version

1.1.869

Game version

4.0.1

CPU

AMD Ryzen 9 5900X

GPU

NVIDIA RTX 3080

RAM

32GB

List of applied mods

No response

Additional context?

No response

@CosmicDreamsOfCode CosmicDreamsOfCode added the bug Something isn't working label Jun 5, 2023
@CosmicDreamsOfCode
Copy link
Author

I looked a bit into this with RenderDoc and the culprit seems to be one of the constant buffers for the fragment shaders
image
on 1.1.741 and afterwards some values are just 0s that were actually set to things before
image

@gdkchan
Copy link
Member

gdkchan commented Jun 5, 2023

Just for reference, that versions corresponds to PR #4711.

@CosmicDreamsOfCode
Copy link
Author

Unsure if this is related to the nature of the PR or if a newer ryujinx version changed something but all the values from before were populated with something different when i was checking something just now, resulting in something quite a bit worse than i initially observed
image

@CosmicDreamsOfCode
Copy link
Author

This seems to possibly be fixed by either game version 8.0.0 or latest Ryujinx updates, not sure.

@gdkchan
Copy link
Member

gdkchan commented Jun 2, 2024

It was fixed by #6794.

@gdkchan gdkchan closed this as completed Jun 2, 2024
@CosmicDreamsOfCode
Copy link
Author

Gotcha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants