Allow per node protection bypass / protection override #11 #9 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Tested this a bit and everything seems to be working as it should. |
S-S-X
added
API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds before_read and before_write callbacks.
Callback return value is checked and it it evaluates to true then read or write is allowed, if false then read/write is disallowed.
Callbacks can be overridden for each registered node, tool wide callback not available.
This also adds parameters for registered nodes:
protection_bypass_read and protection_bypass_write. Both take list of privileges and those privileges will be used to check if protections can be bypassed.
Privilege can for example be "interact" to allow everyone to bypass protection checks.
Implements #11
Dependency for #9