Fix error Class 'S1SYPHOS\SRI\settings' not found in PHP 7.0.2

[mrunkel]

Hey there.. I'm back..

So I installed the new version today and I'm getting an error:

My patches here fix the error, but I'm not sure if it's the cleanest fix.

[S1SYPHOS]

I didn't use settings; in the js.php file, my bad. I successfully tested it on your PHP version.

Anywhoozle, $js|cssOptions were only merged into $attr if $url / $src existed - being checked after appending a timestamp to the filename, thus not being merged at all. I fixed this also.

Thanks for your valuable feedback!

[mrunkel]

No problem. At all. I’ll test the new version tomorrow when I’m in the office.

As for the thanks, they are not necessary, it is, for me, part of the free software contract. You get stuff for free, you better be willing to help out in return.

Should I resubmit my change to the readme for the NGINX rule? I’ll do it if you want, otherwise I’ll just keep using it for myself.

I do think my solution is ‘nicer.’ I’ve tested it pretty extensively here in in development mode, but it’s not in production. That being said, I’ve been writing nginx configs for over 5 years now, so I’m pretty confident in my proposed solution.

Have a great night.

Marc

[S1SYPHOS]

I admire your willingness to fulfill your side of the free software contract. That being said, giving thanks and appropriate credit is part of my personal code of conduct - that, you can and will not escape. Muharhar!

As for your contribution to the NGINX rule: I'm positive about your abilities in this field. The article you linked (thanks btw 👅) clearly stated that problems most likely occur apart from using it to _ just return_ stuff. Since that's the case, I simply doubted that your solution fixes a real-world scenario. If you like, submit your PR and I'll review it - won't hurt to test next time I'm using NGINX & Kirby CMS.

Feel free to prove me wrong, I appreciate when people do that, because I like my learning curve as I like my hillside when hiking: steep.

Now, YOU have a great night, Sir!