Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.3.4 Bug Patch #20

Closed
S4WA opened this issue Oct 24, 2022 · 5 comments
Closed

1.3.4 Bug Patch #20

S4WA opened this issue Oct 24, 2022 · 5 comments
Assignees
@S4WA
Labels
Bug Something isn't working

Comments

@S4WA
Copy link
Owner

S4WA commented Oct 24, 2022 •
edited

Fixing its behavior of openSCTab(), Upload fixed version on Chrome Webstore.
@S4WA S4WA self-assigned this Oct 24, 2022
S4WA added a commit that referenced this issue Oct 24, 2022
@S4WA
Fixing a minor bug #20
d89f412
@S4WA
Copy link
Owner Author

S4WA commented Oct 24, 2022 •
edited

  • Stop publishing the draft on the WebStore.
  • Replace the draft from 6f16628 to 0fad580 as version 1.3.4, on Releases (Github) too.

S4WA added a commit that referenced this issue Oct 24, 2022
@S4WA
Another adjust #20
4ccd676
S4WA added a commit that referenced this issue Oct 26, 2022
@S4WA
Stabilizing #20
bad036c
@S4WA
Copy link
Owner Author

S4WA commented Oct 29, 2022 •
edited

There were a missing if statement on the contents.js.

image

image

It was including an unnecessary query. Usually in_system_playlist is used to be for a recommended private playlist from SoundCloud for each user. If another person who opens an url that have an unnecessary query, the web shows an error that says as a private playlist. In short, It doesn't really matter, however, I had to put an idiot-proof.

in_system_playlist is something like this:

image

image

S4WA added a commit that referenced this issue Oct 29, 2022
@S4WA
whatever #20
d22a727
S4WA added a commit that referenced this issue Oct 29, 2022
@S4WA
Disabled pause on hover for marquee & Less data response #20
3c723fd
@S4WA
Copy link
Owner Author

S4WA commented Oct 29, 2022 •
edited

No need to update & send all of data in every half a second.
image

S4WA added a commit that referenced this issue Oct 29, 2022
@S4WA
#20
73291ad
S4WA added a commit that referenced this issue Oct 29, 2022
@S4WA
#20
155c2ae 
deleted debugs
S4WA added a commit that referenced this issue Oct 30, 2022
@S4WA
#20
5114425
S4WA added a commit that referenced this issue Nov 1, 2022
@S4WA
another adjust #20
abcfff4
S4WA added a commit that referenced this issue Nov 11, 2022
@S4WA
#20
0fad580
S4WA added a commit that referenced this issue Nov 12, 2022
@S4WA
#20
216b71e 
my dumbass
@S4WA
Copy link
Owner Author

S4WA commented Nov 12, 2022 •
edited

Yeah and my dumbass did the same mistake.

@S4WA
Copy link
Owner Author

S4WA commented Nov 13, 2022

MAYBE IT'S BETTER TO OVERHAUL AGAIN? https://stackoverflow.com/questions/27383224/chrome-extension-long-lived-message-connection-how-to-use-callback-functions

S4WA referenced this issue Nov 15, 2022
@S4WA
1.3.4 Replacing fundamental parts #18 #19
6f16628
@S4WA S4WA closed this as completed Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@S4WA S4WA

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@S4WA