Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server tests starter with live reload #129

Merged
merged 5 commits into from Jul 6, 2017

Conversation

aprooks
Copy link
Contributor

@aprooks aprooks commented Jul 4, 2017

starter for #128

what's working: live reload of test project and tests run.

I did not use Expecto Fake helpers, not sure if they would work with 'dotnet watch'

also I noticed at least once that 2 watching process deadlocked. Not sure what to do with it atm.

Signed-off-by: Alexander Prooks aprooks@live.ru

Signed-off-by: Alexander Prooks <aprooks@live.ru>
@forki
Copy link
Member

forki commented Jul 4, 2017

Can't believe we are already at #129 here. ;-) this was just supposed to be a small example. But seems people are interested. Really cool tbh

Signed-off-by: Alexander Prooks <aprooks@live.ru>
Signed-off-by: Alexander Prooks <aprooks@live.ru>
@aprooks
Copy link
Contributor Author

aprooks commented Jul 5, 2017

  • added serverTests project building on default build
  • added running tests via dotnet watch

things to note.

I've made 2 separate tasks for .net framework executables and for running serverTests project via dotnet
also RunServerTests task is put earlier than 'ClientBuild' since I prefer fail fast approach during builds and tests are being completed much faster than fable compilation

@aprooks
Copy link
Contributor Author

aprooks commented Jul 5, 2017

Can't believe we are already at #129 here. ;-) this was just supposed to be a small example. But seems people are interested. Really cool tbh

small examples are very important imho :) I prefer to clone/download full working example and then adjust/delete example code instead of setting up solution from the ground every time

Signed-off-by: Alexander Prooks <aprooks@live.ru>
@aprooks
Copy link
Contributor Author

aprooks commented Jul 5, 2017

it is working for me now ;)

@aprooks aprooks changed the title [WIP] server tests starter with live reload server tests starter with live reload Jul 5, 2017
@alfonsogarciacaro
Copy link
Collaborator

Nice work @aprooks! This looks good to me to merge 😄 Do you have any comment, @forki?

Copy link
Member

@forki forki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff. Just minor nitpicking

open Expecto
open ServerCode

[<Tests>]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use expecto tests without the attribute. I think we don't need that. Thx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, dunno where it came from :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forki removed

Signed-off-by: Alexander Prooks <aprooks@live.ru>
@forki forki merged commit f1e2712 into SAFE-Stack:master Jul 6, 2017
@forki
Copy link
Member

forki commented Jul 6, 2017

💋

@aprooks aprooks deleted the feature/serverTests branch July 6, 2017 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants