Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use elmish #451

Merged
merged 9 commits into from
Mar 8, 2024
Merged

Use elmish #451

merged 9 commits into from
Mar 8, 2024

Conversation

Larocceau
Copy link
Contributor

in response to #448:

  • Use UseElmish hook for pages instead of passing messages on from index

martinbryant
martinbryant approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@martinbryant martinbryant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with @Larocceau and issues resolved

@martinbryant martinbryant merged commit 859f08f into master Mar 8, 2024
1 check passed
@Larocceau Larocceau deleted the use-elmish branch March 8, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinbryant martinbryant martinbryant approved these changes

@isaacabraham isaacabraham Awaiting requested review from isaacabraham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Larocceau @martinbryant