Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fantomas to 4.6 #499

Merged
merged 2 commits into from Jan 15, 2022
Merged

Update Fantomas to 4.6 #499

merged 2 commits into from Jan 15, 2022

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jan 14, 2022

No description provided.

@theimowski
Copy link
Member

Funny coincidence - I was just reviewing 4.6 release notes :)
Any idea why all CI tasks failed with same error?

client: Bundling for production...
client: [webpack-cli] Failed to load '/home/travis/build/SAFE-Stack/SAFE-template/Content/default/webpack.config.js' config
client: [webpack-cli] TypeError: MiniCssExtractPlugin is not a constructor
client:     at Object.<anonymous> (/home/travis/build/SAFE-Stack/SAFE-template/Content/default/webpack.config.js:88:13)
...

master branch builds fine - as you changed only *.fs files I'd guess this could be related to some nasty spacing / line ending issue with Fable?

@nojaf
Copy link
Contributor Author

nojaf commented Jan 14, 2022

Hmm, this feels very unrelated to be honest. I would need to take a closer look as I'm on my phone right now. Who still uses webpack though 😅

@nojaf
Copy link
Contributor Author

nojaf commented Jan 15, 2022

Tried this locally, I get the exact same webpack error with the master branch as with this PR.
I also noticed the package-lock.js is updated when I run dotnet run -- Bundle inside the default folder.
I find this weird.

@nojaf
Copy link
Contributor Author

nojaf commented Jan 15, 2022

Turns out my branch was out of sync 🙈

@theimowski theimowski merged commit 5a58594 into SAFE-Stack:master Jan 15, 2022
@theimowski
Copy link
Member

cool, thanks!

@nojaf nojaf deleted the update-fantomas branch January 15, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants