Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Multiple patches #392

Merged
merged 8 commits into from Jan 31, 2023

Conversation

nullqwertyuiop
Copy link
Contributor

@nullqwertyuiop nullqwertyuiop commented Jan 30, 2023

Close #391

  • Add dependency noneprompt
  • Fixed config_init
    • Fixed import
    • Fixed bot_accounts checking
    • Fixed type checking
    • Add required field host_qq
    • Add duplication check to bot_accounts
  • Fixed --set-config
    • Fixed list converting
    • Fixed child type checking
  • Fixed duplicated MemberLeaveEventKick (Close [Bug Report] mirai_events模块里面踢人事件响应了两遍 #395)

Signed-off-by: nullqwertyuiop null@member.fsf.org

Signed-off-by: nullqwertyuiop <null@member.fsf.org>
Signed-off-by: nullqwertyuiop <null@member.fsf.org>
Signed-off-by: nullqwertyuiop <null@member.fsf.org>
Signed-off-by: nullqwertyuiop <null@member.fsf.org>
Signed-off-by: nullqwertyuiop <null@member.fsf.org>
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 30, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 3.41%.

Quality metrics Before After Change
Complexity 6.66 ⭐ 8.65 🙂 1.99 👎
Method Length 86.41 🙂 89.41 🙂 3.00 👎
Working memory 6.60 🙂 7.21 🙂 0.61 👎
Quality 62.25% 🙂 58.84% 🙂 -3.41% 👎
Other metrics Before After Change
Lines 216 230 14
Changed files Quality Before Quality After Quality Change
main.py 73.06% 🙂 75.01% ⭐ 1.95% 👍
shared/utils/tui.py 55.40% 🙂 49.43% 😞 -5.97% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
shared/utils/tui.py process_info 24 😞 200 😞 19 ⛔ 26.23% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
shared/utils/tui.py set_config 15 🙂 239 ⛔ 38.10% 😞 Try splitting into smaller methods
main.py group_message_handler 0 ⭐ 69 🙂 11 😞 71.61% 🙂 Extract out complex expressions
main.py temp_message_listener 0 ⭐ 69 🙂 10 😞 73.51% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@nullqwertyuiop nullqwertyuiop marked this pull request as ready for review January 30, 2023 15:19
@nullqwertyuiop nullqwertyuiop marked this pull request as draft January 30, 2023 15:42
Signed-off-by: nullqwertyuiop <null@member.fsf.org>
Signed-off-by: nullqwertyuiop <null@member.fsf.org>
Signed-off-by: nullqwertyuiop <null@member.fsf.org>
@nullqwertyuiop nullqwertyuiop marked this pull request as ready for review January 31, 2023 07:43
@SAGIRI-kawaii SAGIRI-kawaii merged commit 9508d89 into SAGIRI-kawaii:Ariadne-v4 Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] mirai_events模块里面踢人事件响应了两遍 [Bug Report] 配置初始化 & 炒饭
2 participants