Merge pull request #542 from tupui/skip_sobol

Fix skip_values integer check
SALib · Oct 17, 2022 · c5cc5f2 · c5cc5f2
2 parents 54d21fe + 72e8b80
commit c5cc5f2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/SALib/sample/sobol.py b/src/SALib/sample/sobol.py
@@ -103,7 +103,7 @@ def sample(
     qrng = qmc.Sobol(d=2 * D, scramble=scramble, seed=seed)
 
     # fast-forward logic
-    if skip_values > 0:
+    if skip_values > 0 and isinstance(skip_values, int):
         M = skip_values
         if not ((M & (M - 1) == 0) and (M != 0 and M - 1 != 0)):
             msg = f"""
@@ -125,7 +125,7 @@ def sample(
             warnings.warn(msg, stacklevel=2)
 
         qrng.fast_forward(M)
-    elif skip_values < 0 or isinstance(skip_values, int):
+    elif skip_values < 0 or not isinstance(skip_values, int):
         raise ValueError("`skip_values` must be a positive integer.")
 
     # sample Sobol' sequence