Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct description of Saltelli's sampling #603

Closed
tupui opened this issue Feb 14, 2024 · 1 comment · Fixed by #604
Closed

Correct description of Saltelli's sampling #603

tupui opened this issue Feb 14, 2024 · 1 comment · Fixed by #604

Comments

@tupui
Copy link
Member

tupui commented Feb 14, 2024

Sergei Kucherenko shared the following with me (sorry I am laking time right now to make a PR, though I thought that could be also left as a good first PR 😅):

I have a remark with regards to SaLib, namely in the Section on Sobol’ Sensitivity Analysis it says: “Saltelli’s scheme extends the Sobol’ sequence in a way to reduce the error rates in the resulting sensitivity index calculations”. This is incorrect. Saltelli indeed proposed a formula to reduce the number of model runs from N ( 2D +1) to N(D+1) ( it was also published at the same time in [1]) but it was I who proposed a formula to reduce the error rates in the resulting sensitivity index calculations. It was firstly published in [1] but typically we give reference [2].

[1] Mauntz W. Global sensitivity analysis of general nonlinear systems. Master’s thesis, Imperial College London, CPSE; 2002. [Supervisors: C. Pantelides and S. Kucherenko.].

[2] Sobol’ I, Tarantola S, Gatelli D, Kucherenko S, Mauntz W. Estimating the approximation error when fixing unessential factors in global sensitivity analysis. Reliab Eng Syst Safety 2007;92:957–60

[3] S. Kucherenko, S. Song, Different numerical estimators for main effect global sensitivity indices. Reliability Engineering and System Safety, 165 (2017) 222-238

I has one trivial but important improvement: in [3] see Improved formula of Sobol’ and Myshetzskay

@ConnectedSystems
Copy link
Member

This is awesome, please pass on my thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants