Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NameIDPolicy AllowCreate hardcoded to true in AuthnRequest #329

Closed
mauromol opened this issue Apr 13, 2021 · 2 comments · Fixed by #359
Closed

NameIDPolicy AllowCreate hardcoded to true in AuthnRequest #329

mauromol opened this issue Apr 13, 2021 · 2 comments · Fixed by #359

Comments

@mauromol
Copy link
Contributor

Currently, if on login I request to set the NameIDPolicy element on the AuthnRequest, its AllowCreate attribute is hardcoded to true. Is there a particular reason for this?
If I had to think of a possible default value for this attribute in the average case, I would say that omitting the attribute (equivalent to set it to false) would be safer, while requesting it to be true could be an opt-in feature. Indeed, allowing the Identity Provider to create a new user on the fly if the principal was not previously identified might not be the most common scenario, might it?
What do you think?

As a concrete example, the Italian SPID system, for instance, requires a special out-of-band registration process for people to get proper credentials, so when a Service Provider starts a login process with SPID, the end user must already have such credentials; hence the SPID specification denies the use of AllowCreate="true".

Do you think the login process could be enhanced to support the specification of the AllowCreate flag? Please note that, if changes in #307 were accepted, from an API point of view this would just need an enrichment to the AuthRequestParams parameter class. The default value may be kept to true for backward compatibility.

@mauromol mauromol changed the title NameIDPolicy AllowCreate` hardcoded to true in AuthnRequest NameIDPolicy AllowCreate hardcoded to true in AuthnRequest Apr 13, 2021
@pitbulk
Copy link
Contributor

pitbulk commented Jul 23, 2021

I'm still considering adding #307 or not, but meanwhile I belive we can add a new parameter "allowCreate" to the login method, by default true.

@mauromol
Copy link
Contributor Author

I'm still considering adding #307 or not, but meanwhile I belive we can add a new parameter "allowCreate" to the login method, by default true.

@pitbulk please have a look at #350: I think it brings actual value to implement features like this in an elegant and sustainable way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants