Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the SamlResponse returned attribute map preserve attribute order #331

Merged

Commits on Apr 13, 2021

  1. Make the SamlResponse returned attribute map preserve attribute order

    The map returned by SamlResposne containing the attributes returned by
    the IdP now preserves the order in which such attributes appear in the
    SAML response XML. This is not strictly mandatory, but a plus.
    Indeed, the test method
    com.onelogin.saml2.test.AuthTest.testProcessResponse() was not
    deterministic before this change: indeed, the iteration order of HashMap
    is undetermined so expecting to see attribute names in a given order
    could lead to a test failure. This change also fixes this and attribute
    names are expected now to be seen in the order in which the
    corresponding attributes appear in the test XML file.
    mauromol committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    1fba07d View commit details
    Browse the repository at this point in the history