Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add factories as an extension mechanism for Auth #352

Merged
merged 7 commits into from
Oct 1, 2021
Merged

Add factories as an extension mechanism for Auth #352

merged 7 commits into from
Oct 1, 2021

Commits on Aug 31, 2021

  1. Add factories as an extension mechanism for Auth 

    This allows library consumers to extend the standard java-saml message
classes with custom implementations while still using the built-in Auth
class to orchestrate the message flow, by providing a mechanism to
plug-in custom object creation logic.
    @mauromol
    mauromol committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    097553b View commit details
    Browse the repository at this point in the history

  2. Change syntax to avoid javac 8 compilation errors 

    It seems like neither Eclipse ecj nor javac in Java 11 complains when
using constructor references in these very special cases used for unit
testing. But javac in Java 8 does. So, we're now using lambda
expressions in place of constructor references: this seems to make all
compilers happy.
    @mauromol
    mauromol committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    1246cd5 View commit details
    Browse the repository at this point in the history

  3. Move message factories to their own package

    @mauromol
    mauromol committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    abd6326 View commit details
    Browse the repository at this point in the history

  4. Improve LogoutResponse API to match LogoutRequest/AuthnRequest ones 

    This introduces LogoutResponseParams and allows to make the whole API
coherent when building outgoing SAML messages. The Auth factories
benefit from this as well, because they now share a common construction
and usage pattern.
    @mauromol
    mauromol committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    11bb45d View commit details
    Browse the repository at this point in the history

  5. Apply minor adjustments to AuthnRequest/LogoutRequest APIs and tests 

    These details were overlooked in the first place: getters of the input
params should better be public and fields can be declared as final.
The useless NameId setter in LogoutRequestParams was temporarily
introduced during development but should have been reverted from the
beginning, so it's gone now.

Some tests were improved to provide more accurate assertions.
    @mauromol
    mauromol committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    41d95ac View commit details
    Browse the repository at this point in the history

  6. Document the new API and extensibility features in README

    @mauromol
    mauromol committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    b54bff0 View commit details
    Browse the repository at this point in the history

  7. Change factory approach to use just a single multi-message factory 

    In this way the API of Auth gets simplified.
    @mauromol
    mauromol committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    2917a41 View commit details
    Browse the repository at this point in the history