Fix metadata validation errors #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are right, SingleLogoutService is EndpointType not IndexedEndpointType, so no isDefault / index allowed. Thanks for contributing that |
|
seems sane 👍 |
pitbulk
added a commit
that referenced
this pull request
Jun 29, 2015
Fix metadata validation errors
pitbulk
added a commit
that referenced
this pull request
Jun 29, 2015
ylansegal
added a commit
to ylansegal/ruby-saml
that referenced
this pull request
Aug 11, 2015
…port_0.9_rebase * upstream/master: (47 commits) Handle empty URI references as per http://www.w3.org/TR/xmldsig-core/#sec-Same-Document; thx to @sixto for resolving a test case failure. support nameid in attribute values first attempt at adding support for scoped attributes needs additional work and tests Add some documentation about the soft setting parameter Update readme.md for 1.0.0 release Update date of the 1.0.0 release Update Readme and changelog Security improvement: Avoid entity expansion (XEE attacks) According to the xsd, the issuer has to be before the status Update changelog Fix SAML-Toolkits#244, related to PR SAML-Toolkits#243. Fix bug on metadata. Reorder KeyDescriptors Add logging information to README Allow logging to be delegated to an arbitrary Logger. Add tests for existing Logging functionality no more silent failure fetching idp metadata fix schema validation errors in service provider metadata tests to validate service provider metadata xml against the schema ignore gemfile.lock files in the gemfiles directory Prepare 1.0.0 release Improve compatibility with namespaces ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are xml schema validation errors with the service provider metadata xml that is generated by
OneLogin::RubySaml::Metadata#generate. The first is thatSingleLogoutServiceisn't allowed to to haveisDefaultandindexattributes. The other is that theAttributeValueelement comes from the assertion schema, not the metadata schema. See the diff for the details.I also added code that validates the xml produced by each test against the schema.