Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More specific error messages for request certificate validation #545

Closed
wants to merge 8 commits into from
Closed

More specific error messages for request certificate validation #545

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a4dc9d3
missing 'soft' variable when executing validate_document_with_cert
FabioCareMonkey Sep 19, 2020
229221e
display error message when it is found that the certificates from idp…
FabioCareMonkey Sep 19, 2020
1c442e4
adding test specs for the bug fixed
FabioCareMonkey Sep 19, 2020
60aa020
adding test specs for the new error message
FabioCareMonkey Sep 19, 2020
11145ab
adjusting error copy
FabioCareMonkey Sep 19, 2020
c3d0b71
adjusting test specs
FabioCareMonkey Sep 19, 2020
52868c4
fixing introduced issue
FabioCareMonkey Sep 19, 2020
9dbfe66
refactoring the reporting of idp_certificates issues so multiple of t…
FabioCareMonkey Oct 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/onelogin/ruby-saml/response.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -863,7 +863,7 @@ def validate_signature
valid = false
expired = false
idp_certs[:signing].each do |idp_cert|
valid = doc.validate_document_with_cert(idp_cert)
valid = doc.validate_document_with_cert(idp_cert, @soft)
if valid
if settings.security[:check_idp_cert_expiration]
if OneLogin::RubySaml::Utils.is_cert_expired(idp_cert)
Expand Down
4 changes: 2 additions & 2 deletions lib/xml_security.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ def validate_document(idp_cert_fingerprint, soft = true, options = {})
validate_signature(base64_cert, soft)
end

def validate_document_with_cert(idp_cert)
def validate_document_with_cert(idp_cert, soft = true)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the softvariable (from line 258) was missing on the scope of this method

# get cert from response
cert_element = REXML::XPath.first(
self,
Expand All @@ -260,7 +260,7 @@ def validate_document_with_cert(idp_cert)

# check saml response cert matches provided idp cert
if idp_cert.to_pem != cert.to_pem
return false
return append_error("SAML response certificate does not match idp certificate", soft)
end
else
base64_cert = Base64.encode64(idp_cert.to_pem)
Expand Down