Error reporting for diagnostics

[christianbpedersen]

Status

READY

Description

This adds some error output.

Todos

• Write tests

Deploy Notes

Steps to Test or Reproduce

bundle exec rake

Impacted Areas in Application

[Lordnibbler]

@christianbpedersen can you please rebase this branch off master and add tests for new code?

[pwnetrationguru]

I've rebased off current master and will look into tests, @Lordnibbler.

[pwnetrationguru]

@pitbulk, @luisvm, @Lordnibbler, rebased and tests added.

[pwnetrationguru]

Oops, look like I missed two cases. Adding now...

[Lordnibbler]

@pwnetrationguru can you please remove the version bump from this branch?

[luisvm]

@pwnetrationguru as per @Lordnibbler, could you please remove the version bump?

[pitbulk]

@pwnetrationguru , we need that you remove version bump, also we have the #147 that includes a new error, can you mix this PR (branch issuer) with your code and add its test?

[pwnetrationguru]

hey all, yep, i'll plan on updating this PR tomorrow! 👍

[pwnetrationguru]

@Lordnibbler, @luisvm and @pitbulk, version bump removed, test added, should be GTG 🐥

[pwnetrationguru]

Oops, looking at #147 now and will add that error

[pwnetrationguru]

@Lordnibbler, @luisvm and @pitbulk, re #147. I think the best approach is merge this PR into master and then comment on #147 to add the errors to @errors

Otherwise, I'm merging in changes from a PR that hasn't been merged into master yet,etc.

Thoughts?

[pitbulk]

@pwnetrationguru You can download the https://github.com/onelogin/ruby-saml/pull/147.patch do a:

git apply 147.patch

and handle with the error issue, then you can close the #147 referencing this PR, then merge this PR and at the end, delete the issuer branch

[pwnetrationguru]

That doesn't seem to follow git best practices. What makes the most sense, to me, is get this merged into master. Then I can checkout the branch associated with #147 and add the @errors object. My suggestion would be:

1. Merge this PR into master
2. Rob opens PR against Fix LogoutResponse issuer validation and implement SAML Response issuer validation. Related to Pull Request 116 #147 to add @errors
3. Merge Fix LogoutResponse issuer validation and implement SAML Response issuer validation. Related to Pull Request 116 #147 into master

[Lordnibbler]

👍, id recommend @pwnetrationguru's steps for git but @pitbulk's will also work