Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: refactor order / metadata / reward calculate #24

Closed
wants to merge 43 commits into from

Conversation

SterlynLee
Copy link
Contributor

Description

  1. use block height to calculate reward
  2. remove reset-store
  3. add OrderFinish to handle reward settlement upon order completion
  4. to remove order instead of set finish/cancel/terminate/expire status
  5. add ignore list in random sp
  6. refund completed shard pledge if order is canceled/expired
  7. worker migrate
  8. fix pledge/worker reward calculate
  9. add worker claim in claim reward
  10. add reward debug log
  11. add expire order in end blocker
  12. remove order status constants in sao module
  13. add migrate status to avoid user to cancel migrating order
  14. refator updateMeta
  15. restrict renew duration
  16. move order expire to model module
  17. move new meta to MsgStore
  18. refactor metadata

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

mattstweb and others added 30 commits January 31, 2023 17:46
this is a change log commit to record code change below
1. use block height to calculate reward
2. remove reset-store
3. add OrderFinish to handle reward settlement upon order completion
4. to remove order instead of set finish/cancel/terminate/expire status
5. add ignore list in random sp
6. refund completed shard pledge if order is canceled/expired
7. worker migrate
8. fix pledge/worker reward calculate
9. add worker claim in claim reward
10. add reward debug log
11. add expire order in end blocker
12. remove order status constants in sao module
13. add migrate status to avoid user to cancel migrating order
14. refator updateMeta
15. restrict renew duration
16. move order expire to model module
17. move new meta to MsgStore
18. refactor metadata
@SterlynLee SterlynLee changed the title !Code Refactoring refactor!: refactor order / metadata / reward calculate Mar 22, 2023
@LeoRSao LeoRSao removed their request for review March 22, 2023 07:44
@SterlynLee SterlynLee closed this Mar 22, 2023
@mattkb mattkb deleted the st/dev_phase3_metadata branch May 24, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants