Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

Commit

Permalink
Merge branch 'prepare-release' into release
Browse files Browse the repository at this point in the history
  • Loading branch information
s4sdkJenkinsBot committed Aug 17, 2020
2 parents 79edb1b + 843c2de commit 3b35f7d
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 35 deletions.
1 change: 0 additions & 1 deletion configuration.md
Expand Up @@ -648,7 +648,6 @@ The executeNpm step is used for all invocations of the npm build tool. It is, fo
| --- | --- | --- | --- |
| `dockerImage` | | `ppiper/node-browsers:v2` | The image to be used for executing npm commands. |
| `defaultNpmRegistry` | | | The default npm registry url to be used as the remote mirror. Bypasses the local download cache if specified. |
| `sapNpmRegistry` | | `https://npm.sap.com` | The default npm registry url to be used as the remote mirror for the SAP npm packages. Bypasses the local download cache if specified. |

#### cloudFoundryDeploy
A step configuration regarding Cloud Foundry deployment. This is required by stages like end-to-end tests, performance tests, and production deployment.
Expand Down
48 changes: 15 additions & 33 deletions release-notes-draft.md
Expand Up @@ -2,42 +2,24 @@

This document describes the changes which will be part of the next release and are already available in the latest version (master branch) of the pipeline.

# v40

## New Features

### Synopsys Detect Scan (formerly BlackDuck) (Beta)

A new 3rd party stage was introduced which allows to execute Detect scans using the project "Piper" step [detectExecuteScan](https://sap.github.io/jenkins-library/steps/detectExecuteScan/).
Please note that the step is currently only available in an early version.
It might not support all variants of projects out-of-the-box.
Furthermore, you might have to configure a Docker image which provides the build tools, e.g. maven, that you want to use during the scan.

The scan can be activated by configuring the step `detectExecuteScan`, for example:

```yaml
steps:
detectExecuteScan:
detectTokenCredentialsId: 'detect-token'
projectName: 'My Example'
projectVersion: '1'
serverUrl: 'https://xyz.blackducksoftware.com'
dockerImage: 'docker-image'
# v41

## :warning: Breaking changes
### Configuration option for SAP NPM Registry
The configuration option `sapNpmRegistry` was removed, due to the migration of all packages from the SAP NPM registry to the default public registry at npmjs.org.
Thus, no separate configuration of the SAP NPM registry is required anymore.
Any configuration for the parameter `sapNpmRegistry` **will be ignored** by the pipeline.
If your project requires a custom registry configuration, use the `defaultNpmRegistry` parameter instead. For example:

```diff
npmExecuteScripts:
defaultNpmRegistry: 'https://registry.npmjs.org/'
- sapNpmRegistry: 'https://...'
```
## New Features

## Fixes

Some stages such as `backendIntegrationTests` can be configured to run with an optional sidecar image.
This was broken for a number of releases, if the Download Cache was enabled and any steps within the stage made use of it (such as `mavenExecute`).
For the time being, docker containers can be connected to one network only, which means the Download Cache has to be disabled for stages with a sidecar image defined.

In `scp-cf-spring` archetype maven-based MTA projects, the pipeline installed the wrong `application`-module artifact which broke the ability to run integration tests.
This was fixed in the [library](https://github.com/SAP/jenkins-library/pull/1892).
The frontend integration tests where not run in versions v39 and v40 of the pipeline, because the technical name of the stage was not correctly passed to the new go-implemented steps introduced in v39. The stage Frontend Integration Tests was nevertheless shown as successful.

## Improvements

For a step which anticipates to run with an optional sidecar image, the image may now also be defined in that step's configuration only.
This improves performance versus configuring the sidecar image in the stage, since it avoids running other steps within the stage also with that sidecar.

:warning: **If the Download Cache is enabled**, sidecar images have to be configured in the stage as before.
The Download Cache is enabled by default on CX-Server-based Jenkins instances, unless when running Jenkins in a Kubernetes environment.
2 changes: 1 addition & 1 deletion s4sdk-pipeline.groovy
@@ -1,6 +1,6 @@
#!/usr/bin/env groovy

final def pipelineSdkVersion = 'v40'
final def pipelineSdkVersion = 'v41'

library "s4sdk-pipeline-library@${pipelineSdkVersion}"
cloudSdkPipeline(script: this)

0 comments on commit 3b35f7d

Please sign in to comment.