Merging cost object documentation into Workflow documentation #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajatk-sap
reviewed
May 30, 2024
| @@ -101,64 +121,222 @@ PATCH operations in Expense Reports v4 conform to the JSON Merge Patch specifica | |||
|
|
|||
| * [Approve/SendBack/Recall Report Response](#patch-approve-sendback-recall-report-response-schema) | |||
|
|
|||
| ### Example | |||
| ## View Cost Objects for a specific Report | |||
There was a problem hiding this comment.
Should we call this as "Get" instead of "View" ?
| * [RFC 7231 Accept-Encoding](https://tools.ietf.org/html/rfc7231#section-5.3.4) | ||
| * [RFC 7235 Authorization](https://tools.ietf.org/html/rfc7235#section-4.2) - Bearer Token that identifies the caller. | ||
| This is the Company or User access token. | ||
| * `Concur-CorrelationId` is a Concur specific custom header used for technical support in the form of |
There was a problem hiding this comment.
We are not exposing Concur-CorrelationId. It is considered as internal only param. Remove.
| ```shell | ||
| curl --location --request GET https://integration.api.concursolutions.com/expensereports/v4/users/aa024d31-95eb-4270-b9yz-cb6b5f558a7c/reports/97F923D6935D4426BF9C/costObjectsForApprover | ||
| --header 'Authorization: Bearer {access_token}' \ | ||
| --header 'Concur-CorrelationId: abcd-efgh-xyzw' \ |
There was a problem hiding this comment.
We are not exposing Concur-CorrelationId. It is considered as internal only param. Remove.
rajatk-sap
reviewed
May 30, 2024
| | `currencyCode` | `string` | - | **Required** The 3-letter ISO 4217 currency code for the expense report currency, based on the user's assigned reimbursement currency when the report was created. Examples: `USD` - US dollars; `BRL` - Brazilian real; `CAD` - Canadian dollar; `CHF` - Swiss franc; `EUR` - Euro; `GBO` - Pound sterling; `HKD` - Hong Kong dollar; `INR` - Indian rupee; `MXN` - Mexican peso; `NOK` - Norwegian krone; `SEK` - Swedish krona | | ||
| | `value` | `number` | `double` | **Required** The amount in the defined currency. | | ||
|
|
||
| ### <a name="error-message-schema"></a>ErrorMessage |
There was a problem hiding this comment.
We already have this schema defined at the end
| | `timestamp` | `string` | `date-time` | **Required** The time when the error was captured. | | ||
| | `validationErrors` | [`ValidationError`](#validation-error-schema) | - | The validation error messages. | | ||
|
|
||
| ### <a name="validation-errors-schema"></a>ValidationError |
There was a problem hiding this comment.
We already have this schema defined at the end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.concur.com/browse/ERS-16983
Background:
Between Project Manager Transitions an externalization effort was not fully completed. The goal of this Jira is to finish the job, and get the end point costObjectsForApprover fully available in general access.