initial version of java custom handlers #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now also works in active and draft mode
this fixes handling of virtual elements in projections
this speeds up Java builds (or mvn spring-boot:run) in case no CDS files were changed. use it like this: `mvn spring-boot:run -Pno-cds`
…f UI tests" This reverts commit 9e4aae3.
not going via the starter as we need to avoid security for now.
normally one would do this via recalculating the values but this does not work as the value is not calculated but triggered/written by a custom handler during the lifetime of the draft. There's no way to recalculate this.
Required loginwith user/pw admin/admin. Middleware in ui5.yaml should use admin for basicAuth but this is not working yet: Routes /travel_processor/webapp/index.html and /travel_processor/webapp/test/integration/opaTests.qunit.html are still opening logon dialog.
(1) start the Java or Node.js server (2) start the UI5 server (cd app/travel_processor && npm start)
# Conflicts: # app/travel_processor/package-lock.json
This reverts commit fa01e7f.
The MTA build (currently for the Node.js version only) comes up with a build profile for the Java stack by default, which does not work of course. This change defines build settings in package.json for the Node stack explicitly, and selects the corresponding profile in the mta.yaml file.
since we have introduced security model-wise it does not make sense anymore to exclude security modules. re-introduced them and also use @WithMockUser in the smoke tests.
those dates will change in the future.
In order to update the traveStatus_code we need to update through the PersistenceService.
some how the method for that lost it's annotation and was not called anymore.
stewsk
reviewed
Oct 25, 2021
| @@ -15,7 +15,7 @@ | |||
| }, | |||
| "dataSources": { | |||
| "mainService": { | |||
| "uri": "processor/", | |||
| "uri": "/processor/", | |||
There was a problem hiding this comment.
this will break the node (and probably also the java) version of the app when deployed to CF
is there a way to run without the leading / ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is work in progress