Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Books: Show Genre as drop-down #511

Merged
merged 1 commit into from
May 24, 2023

Conversation

PierreFritsch
Copy link
Contributor

In the Manage Books app, proposal to display the Genre input field as a drop-down (instead of a dialog)

Genre as drop-down

Copy link
Member

@chgeo chgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chgeo chgeo merged commit 3d58e00 into SAP-samples:main May 24, 2023
3 checks passed
@PierreFritsch
Copy link
Contributor Author

Note on accessibility. Description of the current ComboBox behavior as generated by CAP with Fiori Elements.

In Safari 16.5 on macOS Ventura 13.4, with VoiceOver activated on the Genre combo box:

  • first, the VoiceOver cursor is located on the input field (e.g. "Speech, Genre, list box pop up, Menu pop-up combo box"),
  • then, when moving the VoiceOver cursor further, the VoiceOver cursor is located on the "Show Value Help" button of the combo box, which can be activated to display the possible values.

Speech Genre list box popup menu pop up combo box

Show value help

gregorwolf pushed a commit to gregorwolf/cloud-cap-samples that referenced this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants