Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for container groups #73

Merged
merged 7 commits into from
May 9, 2022

Conversation

Meyer-J
Copy link
Contributor

@Meyer-J Meyer-J commented May 9, 2022

  • Add 'createGroup' and 'dropGroup' commands to create and drop HDI container groups.
  • Add the container group name as optional parameter to 'createContainer' and 'dropContainer'.

@cla-assistant
Copy link

cla-assistant bot commented May 9, 2022

CLA assistant check
All committers have signed the CLA.

@jung-thomas
Copy link
Contributor

Thanks so much for the submission. It looks very nice. Let me set aside some time this afternoon (in a few hours) and I'll go through it in detail, merge/test, and if everything looks good I'll cut a new release with this in it.

Thanks,
Thomas Jung

@jung-thomas jung-thomas self-assigned this May 9, 2022
@jung-thomas jung-thomas self-requested a review May 9, 2022 16:16
@jung-thomas jung-thomas added the enhancement New feature or request label May 9, 2022
@jung-thomas jung-thomas merged commit 4c6bfc1 into SAP-samples:main May 9, 2022
@jung-thomas
Copy link
Contributor

I've created the new version 3.202205.1 and released it to npm:
https://www.npmjs.com/package/hana-cli/v/3.202205.1
Thanks again for the contribution!

@Meyer-J Meyer-J deleted the containergroups branch July 19, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants