Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

links to examples are broken #3

Closed
larshp opened this issue Sep 8, 2021 · 7 comments
Closed

links to examples are broken #3

larshp opened this issue Sep 8, 2021 · 7 comments
Assignees

Comments

@larshp
Copy link

larshp commented Sep 8, 2021

in the readme,

Example: [/showcaseBadges/your.SCN.ID](/showcaseBadges/your.SCN.ID)

this links to https://github.com/SAP-samples/sap-community-activity-badges/blob/main/showcaseBadges/your.SCN.ID which is a 404

should this link to https://devrel-tools-prod-scn-badges-srv.cfapps.eu10.hana.ondemand.com/showcaseBadges/your.SCN.ID instead?

is devrel-tools-prod-scn-badges-srv.cfapps.eu10.hana.ondemand.com a server that will keep running?

@jung-thomas jung-thomas self-assigned this Sep 8, 2021
@jung-thomas
Copy link
Contributor

Actually it's a relative URL on purpose. We use the README.md as the source content of the root of the service when running:
https://devrel-tools-prod-scn-badges-srv.cfapps.eu10.hana.ondemand.com/

It's also designed so if people wanted they could fork, adapt, reuse, and then deploy the service on their own account. The relative URL in the README would then still work.

https://github.com/SAP-samples/sap-community-activity-badges/blob/main/srv/routes/intro.js#L12

@jung-thomas
Copy link
Contributor

Although the activity cards are something we will detail more in about two weeks. They will go along with another surprise element of Devtoberfest that isn't quite ready yet.

@jung-thomas
Copy link
Contributor

Although I get what you are seeing since we reused the same content on the project readme. I will do some cleanup there this afternoon to be a more holistic README for the whole project. I missed that on my to-do list. But full details on the whole project will have to wait until the above mentioned surprise. ;)

@larshp
Copy link
Author

larshp commented Sep 8, 2021

no worries, just stumbled across it 😄

@jung-thomas
Copy link
Contributor

I am curious since you were looking around in the repo; did you already find the @larshp specific Easter Egg?

@larshp
Copy link
Author

larshp commented Sep 8, 2021

I didnt read any of the code/files, but now I will look through it :)

@larshp
Copy link
Author

larshp commented Sep 8, 2021

found it, yiiiha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants